Skip to content

Correct the names of the new uncompiled presets#367

Merged
aomarks merged 1 commit intoPolymer:masterfrom
benjaminrancourt:ranb2002-uncompiled-presets
May 11, 2018
Merged

Correct the names of the new uncompiled presets#367
aomarks merged 1 commit intoPolymer:masterfrom
benjaminrancourt:ranb2002-uncompiled-presets

Conversation

@benjaminrancourt
Copy link
Copy Markdown
Contributor

Correct the names of the new uncompiled presets as build names must be unique

Correct the names of the new uncompiled presets as build names must be unique
@aomarks aomarks self-requested a review May 11, 2018 02:42
@aomarks
Copy link
Copy Markdown
Member

aomarks commented May 11, 2018

Good catch, thanks.

@aomarks aomarks merged commit 4ceb421 into Polymer:master May 11, 2018
@benjaminrancourt benjaminrancourt deleted the ranb2002-uncompiled-presets branch May 11, 2018 02:43
aomarks added a commit that referenced this pull request May 11, 2018
justinfagnani pushed a commit that referenced this pull request Jul 10, 2018
…` as `PolymerElement` (#367)

* Rename 'polymer.html' to 'polymer-legacy.js'.

* fix the convertedFilePath logic

* Scope 'polymer.html' -> 'polymer-legacy.js' renaming to packages named 'polymer'.

* add rewrite logic for Polymer.Element -> PolymerElement

* wip - stop sharing a top-level includes, run package-relative always

* Fix comment to more clearly indicate that it's pointing out a bug, not intended behavior.

* Clean up name replacements.

* reformat tests

* Explicitly test 'polymer.html' -> 'polymer-legacy.js' renaming both with and without the './' prefix.

* Test that only files named 'polymer.html' at the root of the package are renamed.

* Remove unnecessary quote escapes.

* Add `getScriptConvertedFilePath` to convert `OriginalDocumentUrl`s of files which were already scripts to `ConvertedDocumentFilePath`s.

* fix polymer override check

* whoops, fix the fix for polymer-legacy renaming

* Fix conversion functions in PackageUrlHandler; always scan all dependencies of a package during conversion.

* Fix `PackageUrlHandler`'s `getOriginalPackageNameForUrl` and `packageRelativeConvertedUrlToConvertedDocumentFilePath`.

* Revert removed filtering in package scanner.

* fix the shady-unscoped-style-import-css.html issue

* Entrypoints for packages can be given in `ConversionSettings`; `ProjectScanner` defaults to reading entrypoints from 'bower.json'; update tests with entrypoint mappings.

* Remove unused `analyzer` parameter from `createDefaultConversionSettings`.

* Remove commented code; `x ? x : y` -> `x || y`; update tests. (...)

- Tests: `convert`'s `entrypoints` property in the arguments object now requires
  that the user completely replaces the map, rather than automatically adding a
  "some-package" entry, if one isn't in the given map.

* `PackageScanner#scanDocument`: replace optional `forceJs` parameter with required `scanAs` parameter.

* Set entrypoints for new tests from master.

* Handle cases where 'bower.json' does not exist in a package, causing an error to be thrown.

* Fix `PackageUrlHandler#getPackageDir`.

* Add new `entrypoints` conversion option to tests.

* `entrypoints` -> `packageEntrypoints`

* Add comments at the point the 'polymer.html' -> 'polymer-legacy.html' renaming happens.

* Update fixtures.

* update CHANGELOG.md

* Update example in README.md .

* Claim added TODO.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants