Correct the names of the new uncompiled presets#367
Merged
aomarks merged 1 commit intoPolymer:masterfrom May 11, 2018
benjaminrancourt:ranb2002-uncompiled-presets
Merged
Correct the names of the new uncompiled presets#367aomarks merged 1 commit intoPolymer:masterfrom benjaminrancourt:ranb2002-uncompiled-presets
aomarks merged 1 commit intoPolymer:masterfrom
benjaminrancourt:ranb2002-uncompiled-presets
Conversation
Correct the names of the new uncompiled presets as build names must be unique
Member
|
Good catch, thanks. |
aomarks
added a commit
that referenced
this pull request
May 11, 2018
justinfagnani
pushed a commit
that referenced
this pull request
Jul 10, 2018
…` as `PolymerElement` (#367) * Rename 'polymer.html' to 'polymer-legacy.js'. * fix the convertedFilePath logic * Scope 'polymer.html' -> 'polymer-legacy.js' renaming to packages named 'polymer'. * add rewrite logic for Polymer.Element -> PolymerElement * wip - stop sharing a top-level includes, run package-relative always * Fix comment to more clearly indicate that it's pointing out a bug, not intended behavior. * Clean up name replacements. * reformat tests * Explicitly test 'polymer.html' -> 'polymer-legacy.js' renaming both with and without the './' prefix. * Test that only files named 'polymer.html' at the root of the package are renamed. * Remove unnecessary quote escapes. * Add `getScriptConvertedFilePath` to convert `OriginalDocumentUrl`s of files which were already scripts to `ConvertedDocumentFilePath`s. * fix polymer override check * whoops, fix the fix for polymer-legacy renaming * Fix conversion functions in PackageUrlHandler; always scan all dependencies of a package during conversion. * Fix `PackageUrlHandler`'s `getOriginalPackageNameForUrl` and `packageRelativeConvertedUrlToConvertedDocumentFilePath`. * Revert removed filtering in package scanner. * fix the shady-unscoped-style-import-css.html issue * Entrypoints for packages can be given in `ConversionSettings`; `ProjectScanner` defaults to reading entrypoints from 'bower.json'; update tests with entrypoint mappings. * Remove unused `analyzer` parameter from `createDefaultConversionSettings`. * Remove commented code; `x ? x : y` -> `x || y`; update tests. (...) - Tests: `convert`'s `entrypoints` property in the arguments object now requires that the user completely replaces the map, rather than automatically adding a "some-package" entry, if one isn't in the given map. * `PackageScanner#scanDocument`: replace optional `forceJs` parameter with required `scanAs` parameter. * Set entrypoints for new tests from master. * Handle cases where 'bower.json' does not exist in a package, causing an error to be thrown. * Fix `PackageUrlHandler#getPackageDir`. * Add new `entrypoints` conversion option to tests. * `entrypoints` -> `packageEntrypoints` * Add comments at the point the 'polymer.html' -> 'polymer-legacy.html' renaming happens. * Update fixtures. * update CHANGELOG.md * Update example in README.md . * Claim added TODO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the names of the new uncompiled presets as build names must be unique